linux-kernel - Re: [Intel-gfx] [PATCH] Samsung laptop driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090826163222.GD22474@kroah.com>
Date:	Wed, 26 Aug 2009 09:32:22 -0700
From:	Greg KH <greg@...ah.com>
To:	Bruno Prémont <bonbons@...ux-vserver.org>
Cc:	linux-kernel@...r.kernel.org, intel-gfx@...ts.freedesktop.org,
	Soeren Sonnenburg <bugreports@....de>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Jérémie Huchet <jeremie@...ah.info>
Subject: Re: [Intel-gfx] [PATCH] Samsung laptop driver

On Sat, Aug 22, 2009 at 12:07:01PM +0200, Bruno Prémont wrote:
> On Fri, 21 August 2009 Greg KH <greg@...ah.com> wrote:
> > From: Greg Kroah-Hartman <gregkh@...e.de>
> > Subject: Samsung laptop driver
> > 
> > This driver implements backlight controls for Samsung laptops that
> > currently do not have ACPI support for this control.
> > 
> > It has been tested on the N130 laptop and properly works there.
> > 
> > Many thanks to Dmitry Torokhov <dmitry.torokhov@...il.com> for
> > cleanups and other suggestions on how to make the driver simpler.
> 
> Hm, that one fails to compile here:
>   CC [M]  drivers/platform/x86/samsung-laptop.o
> /usr/src/linux-2.6/drivers/platform/x86/samsung-laptop.c: In function 'sabi_get_command':
> /usr/src/linux-2.6/drivers/platform/x86/samsung-laptop.c:141: error: implicit declaration of function 'msleep'
> make[5]: *** [drivers/platform/x86/samsung-laptop.o] Error 1
> make[4]: *** [drivers/platform/x86] Error 2
> make[3]: *** [drivers/platform] Error 2
> make[2]: *** [drivers] Error 2
> make[2]: *** Waiting for unfinished jobs....
> 
> Missing a #include <linux/delay.h>?

Yes, I've added it now, thanks.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/