[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090826182459.GD13632@elte.hu>
Date: Wed, 26 Aug 2009 20:24:59 +0200
From: Ingo Molnar <mingo@...e.hu>
To: Pierre Habouzit <pierre.habouzit@...ersec.com>
Cc: Paul Mackerras <paulus@...ba.org>,
Peter Zijlstra <a.p.zijlstra@...llo.nl>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf tools: do not complain if root is owning perf.data
* Pierre Habouzit <pierre.habouzit@...ersec.com> wrote:
> This improves patch fa6963b24 so that perf.data stuff that has
> been dumped as root can be read (annotate/report) by a user
> without the use of the --force.
>
> Rationale is that root has plenty of ways to screw us (usually)
> that do not require twisted schemes involving specially crafting a
> perf.data.
>
> Signed-off-by: Pierre Habouzit <pierre.habouzit@...ersec.com>
> ---
> tools/perf/builtin-annotate.c | 4 ++--
> tools/perf/builtin-report.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
Ok, this makes sense - but i think we should do this in .32 only,
with a Cc: <stable@...nel.org> backport tag for .31.1.
Mind doing it against the latest perfcounters tree, which can be
found in -tip:
http://people.redhat.com/mingo/tip.git/README
your current version does not apply cleanly as the surrounding code
has changed a bit already.
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists