linux-kernel - Re: [PATCH 1/2] ACPI processor: force throttling state when BIOS returns incorrect value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090826121619.2bc7e72b.akpm@linux-foundation.org>
Date:	Wed, 26 Aug 2009 12:16:19 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Frans Pop <elendil@...net.nl>
Cc:	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	lenb@...el.com, rui.zhang@...el.com
Subject: Re: [PATCH 1/2] ACPI processor: force throttling state when BIOS
 returns incorrect value

On Mon, 17 Aug 2009 14:43:34 +0200
Frans Pop <elendil@...net.nl> wrote:

> --- a/drivers/acpi/processor_throttling.c
> +++ b/drivers/acpi/processor_throttling.c
> @@ -62,7 +62,8 @@ struct throttling_tstate {
>  #define THROTTLING_POSTCHANGE      (2)
>  
>  static int acpi_processor_get_throttling(struct acpi_processor *pr);
> -int acpi_processor_set_throttling(struct acpi_processor *pr, int state);
> +int acpi_processor_set_throttling(struct acpi_processor *pr,
> +						int state, bool force);
>  

WARNING: externs should be avoided in .c files
#74: FILE: drivers/acpi/processor_throttling.c:65:
+int acpi_processor_set_throttling(struct acpi_processor *pr,

total: 0 errors, 1 warnings, 137 lines checked

checkpatch speaketh truth - there's already a declaration in
acpi/processor.h anyway.

I'll leave it alone though.  Cleaning up acpi code isn't on the agenda
for today.

Please integrate checkpatch into your patch preparation tools.  It
finds stuff.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/