linux-kernel - Re: PPC driver - generic bus width

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1251296565.7492.7.camel@concordia>
Date:	Thu, 27 Aug 2009 00:22:45 +1000
From:	Michael Ellerman <michael@...erman.id.au>
To:	Alemao <xcarandiru@...il.com>
Cc:	linux-kernel@...r.kernel.org, linuxppc-dev@...abs.org
Subject: Re: PPC driver - generic bus width

On Wed, 2009-08-26 at 10:25 -0300, Alemao wrote:
> Hi all,
> 
> Im trying to develop a driver for my device, and its data bus can be 8, 16
> or 32 bits. This information is passed through the device tree source.
> My code is like this:
> 
> struct device_info_t {
> 	void (*read)();
> 	void (*write)();
> };
> 
> static int __devinit device_probe()
> {
> 	prop = of_get_property(ofdev->node, "bus-width", &size);
> 
> 	device->bus_width = *prop;
> 
> 	switch (device->bus_width) {
> 	case 8:
> 		device->read  = in_8;
> 		device->write = out_8;
> 		break;
> 	case 16:
> 		device->read  = in_be16;
> 		device->write = out_be16;
> 		break;
> 	case 32:
> 		device->read  = in_be32;
> 		device->write = out_be32;
> 		break;
> 	default:
> 		break;
> 	}
> }
> 
> Can someone point me some driver that is doing something similar to the
> ideia shown above?
> 
> Or what Im doing wrong in my code? Cause Im getting erros (warnings) like:
> 
> cc1: warnings being treated as errors
> drivers/dev_test.c:37: warning: function declaration isn't a prototype
> drivers/dev_test.c:38: warning: function declaration isn't a prototype
> drivers/dev_test.c: In function 'device_probe':
> drivers/dev_test.c:113: warning: assignment from incompatible pointer
> type

I'm not sure about the first two, you don't seem to have pasted all the
source, and you haven't given the line numbers.

The 3rd is probably because the prototype for in_8 etc. doesn't match
your structure.

cheers

Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)