linux-kernel - h8300: bad test of memory_end in setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <4A9637B7.1080707@gmail.com>
Date:	Thu, 27 Aug 2009 09:37:27 +0200
From:	Roel Kluin <roel.kluin@...il.com>
To:	ysato@...rs.sourceforge.jp,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: h8300: bad test of memory_end in setup_arch()

in arch/h8300/kernel/setup.c:116:
	if ((memory_end < CONFIG_BLKDEV_RESERVE_ADDRESS) && 
            (memory_end > CONFIG_BLKDEV_RESERVE_ADDRESS))
            /* overlap userarea */
            memory_end = CONFIG_BLKDEV_RESERVE_ADDRESS;

This will always evaluate to false. what is this supposed to do?
is this &&/|| confusion? Can we simply replace this with:

	memory_end = CONFIG_BLKDEV_RESERVE_ADDRESS;

Roel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/