linux-kernel - Re: [PATCH] allow disabling IMA at runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 27 Aug 2009 19:49:19 +0930
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Kyle McMartin <kyle@...artin.ca>, zohar@...ibm.com,
	linux-kernel@...r.kernel.org, eparis@...hat.com,
	torvalds@...ux-foundation.org, James Morris <jmorris@...ei.org>
Subject: Re: [PATCH] allow disabling IMA at runtime

On Thu, 27 Aug 2009 09:32:25 am Andrew Morton wrote:
>   From my reading of kernel/params.c:parse_args(), every __setup()
>   function which returns `1' should result in printk("%s: `%s' invalid
>   for parameter `%s'), so I'm all confused and giving up.

Nope, it's an "obsolete_param", so non-zero means success.

> > +__setup("ima=", ima_enabled);
> 
> Are we supposed to use core_param() nowadays?

Yeah, if this had backwards compatibility requirements.  But for new,
non-core params like this:

1) make sure the module is called "ima" (even if not a module: make the
   object ima.o)

2) use module_param(), and make your parameters "disable" and "audit"
   (ima_disable and ima_audit if must be nonstatic and use module_param_named).
   You don't need to write any parse functions at all!

3) Tell users to use ima.disable and ima.audit.

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/