linux-kernel - Re: mmotm 2009-08-24-16-24 uploaded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090827105209.GA8469@redhat.com>
Date:	Thu, 27 Aug 2009 12:52:09 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: mmotm 2009-08-24-16-24 uploaded

On 08/27, KAMEZAWA Hiroyuki wrote:
>
> On Thu, 27 Aug 2009 12:08:46 +0200
> Oleg Nesterov <oleg@...hat.com> wrote:
>
> >
> > OK, I seem to understand what happens. Could you try the patch below?
> >
>
> worked.

Thanks. I need to think a bit, then I send the fix.

> IMHO, it's necessary to "wake up parent with -ECHILD if all children dies"

Of course! It was supposed to do. More precisely, we should wake up when
any child which cuould be interesting to ->parent dies. No need to check
"all children died" case specially. If parent sleeps on ->wait_chldexit
there must be at least on eligible child.

The problem is, do_notify_parent() changes ->exit_signal _before_ it calls
__wake_up_parent(). This changes the result of eligible_child().

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/