linux-kernel - Re: [RFC, PATCH] filesystem freeze: fix sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A967909.1040609@oss.ntt.co.jp>
Date:	Thu, 27 Aug 2009 21:16:09 +0900
From:	Fernando Luis Vázquez Cao 
	<fernando@....ntt.co.jp>
To:	Christoph Hellwig <hch@....de>
CC:	t-sato@...jp.nec.com, m-hamaguchi@...jp.nec.com,
	Al Viro <viro@...iv.linux.org.uk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Eric Sandeen <sandeen@...hat.com>
Subject: Re: [RFC, PATCH] filesystem freeze: fix sys_umount induced perpetual
 freeze

Christoph Hellwig wrote:
> On Thu, Aug 27, 2009 at 07:11:29PM +0900, Fernando Luis V?zquez Cao wrote:
>> Thank you for the pointers. I gave those patches a spin, but it seems
>> the umount case is not being tackled. I suggest rejecting the umount
>> for frozen filesystems. What do you think?
>>
>> I will be replying to this email with a forward port of your patches
>> along with my own patches that fix the locking for umount and add a
>> new ioctl to check the freeze state of the filesystem (this is helpful
>> to create clean resource agents for HA solutions).
> 
> I think we should just reject the umount for a forzen filesystem with
> -EBUSY like I do for remount in those patches.  I somehow thought I did
> this but didn't.  Is that good for your use case?

Yes, absolutely. Today I will be sending patches that do just that.
Hopefully you will find the new ioctl (ISFROZEN) I am adding
helpful too.

Thanks,

Fernando
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/