linux-kernel - Re: [PATCH] m68k: avoid pgprot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <10f740e80908270518u3812b96ew574eabff21f369e5@mail.gmail.com>
Date:	Thu, 27 Aug 2009 14:18:05 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Heiko Carstens <heiko.carstens@...ibm.com>
Cc:	Greg Ungerer <gerg@...inux.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] m68k: avoid pgprot_noncached redefinition

On Thu, Aug 27, 2009 at 13:41, Heiko Carstens<heiko.carstens@...ibm.com> wrote:
> From: Heiko Carstens <heiko.carstens@...ibm.com>
>
> While compiling m68k with defconfig I get tons if these warnings:
>
> /home2/heicarst/linux-2.6/arch/m68k/include/asm/pgtable_mm.h:148:1: warning: "pgprot_noncached" redefined
> In file included from /home2/heicarst/linux-2.6/arch/m68k/include/asm/pgtable_mm.h:138,
>  from /home2/heicarst/linux-2.6/arch/m68k/include/asm/pgtable.h:4,
>  from include/linux/mm.h:38,
>  from /home2/heicarst/linux-2.6/arch/m68k/include/asm/atarihw.h:134,
>  from arch/m68k/atari/debug.c:20:
> include/asm-generic/pgtable.h:133:1: warning: this is the location of the previous definition
>
> Reason for this is that asm-generic/pgtable.h gets included in pgtable_mm.h
> before pgprot_noncached gets defined.
> So the check "#ifndef pgprot_noncached" in the generic header file is too early.
> Solve this by including the generic header file after the arch define.

Thanks, but Linus has just pulled the fix last night.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/