linux-kernel - [PATCH] ipv4: make ip_append_data() handle NULL routing table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20090827132658.GA17099@cr0.org>
Date:	Thu, 27 Aug 2009 15:26:58 +0200
From:	Julien TINNES <julien@....org>
To:	linux-kernel@...r.kernel.org
Cc:	torvalds@...ux-foundation.org, davem@...emloft.net,
	security@...nel.org, taviso@....lonestar.org
Subject: [PATCH] ipv4: make ip_append_data() handle NULL routing table

Add a check in ip_append_data() for NULL *rtp to prevent future bugs in callers from being exploitable.

Signed-off-by: Julien Tinnes <julien@....org>
Signed-off-by: Tavis Ormandy <taviso@....lonestar.org>
Acked-by: David S. Miller <davem@...emloft.net>

---

diff -r b3cbf0ceeb34 net/ipv4/ip_output.c
--- a/net/ipv4/ip_output.c	Mon Aug 24 14:48:29 2009 +0200
+++ b/net/ipv4/ip_output.c	Thu Aug 27 15:20:36 2009 +0200
@@ -814,6 +814,8 @@
 			inet->cork.addr = ipc->addr;
 		}
 		rt = *rtp;
+		if (unlikely(!rt))
+			return -EFAULT;
 		/*
 		 * We steal reference to this route, caller should not release it
 		 */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/