linux-kernel - Re: [PATCH] txx9wdt.c:52: Fix txx9wdt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090827.235200.21363768.anemo@mba.ocn.ne.jp>
Date:	Thu, 27 Aug 2009 23:52:00 +0900 (JST)
From:	Atsushi Nemoto <anemo@....ocn.ne.jp>
To:	roel.kluin@...il.com
Cc:	wim@...ana.be, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] txx9wdt.c:52: Fix txx9wdt_probe() cleaning up after
 errors

On Tue, 25 Aug 2009 11:20:26 +0200, Roel Kluin <roel.kluin@...il.com> wrote:
> Make txx9wdt_probe() clean up after errors.
> 
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> ---
> Any comments?

Well, why is this patch needed?  I intentionally omitted iounmap and
release_mem_region because devres guarantee these resources are freed
on probe failure.  Or are there any leaks?

---
Atsushi Nemoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/