linux-kernel - Re: [PATCH 02/24] io-controller: Core of the elevator fair queuing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090827210848.GA3821@redhat.com>
Date:	Thu, 27 Aug 2009 17:08:48 -0400
From:	Vivek Goyal <vgoyal@...hat.com>
To:	Gui Jianfeng <guijianfeng@...fujitsu.com>
Cc:	linux-kernel@...r.kernel.org,
	containers@...ts.linux-foundation.org, dm-devel@...hat.com,
	jens.axboe@...cle.com, ryov@...inux.co.jp,
	balbir@...ux.vnet.ibm.com, righi.andrea@...il.com,
	nauman@...gle.com, dpshah@...gle.com, lizf@...fujitsu.com,
	mikew@...gle.com, fchecconi@...il.com, paolo.valente@...more.it,
	fernando@....ntt.co.jp, s-uchida@...jp.nec.com, taka@...inux.co.jp,
	jmoyer@...hat.com, dhaval@...ux.vnet.ibm.com,
	m-ikeda@...jp.nec.com, agk@...hat.com, akpm@...ux-foundation.org,
	peterz@...radead.org, jmarchan@...hat.com
Subject: Re: [PATCH 02/24] io-controller: Core of the elevator fair queuing

On Thu, Aug 27, 2009 at 10:49:40AM +0800, Gui Jianfeng wrote:
> Vivek Goyal wrote:
> ...
> > +static void update_min_vdisktime(struct io_service_tree *st)
> > +{
> > +	u64 vdisktime;
> > +
> > +	if (st->active_entity)
> > +		vdisktime = st->active_entity->vdisktime;
> > +
> > +	if (st->rb_leftmost) {
> > +		struct io_entity *entity = rb_entry(st->rb_leftmost,
> > +						struct io_entity, rb_node);
> > +
> > +		if (!st->active_entity)
> > +			vdisktime = entity->vdisktime;
> > +		else
> > +			vdisktime = min_vdisktime(vdisktime, entity->vdisktime);
> > +	}
> > +
> > +	st->min_vdisktime = max_vdisktime(st->min_vdisktime, vdisktime);
> > +}
> 
> block/elevator-fq.c: In function ‘elv_ioq_slice_expired’:
> block/elevator-fq.c:132: warning: ‘vdisktime’ may be used uninitialized in this function
> LD      block/built-in.o
> 
> We'd better initialize vdisktime at first.
> 

Thanks Gui. Will fix in next posting.

Vivek

> Signed-off-by: Gui Jianfeng <guijianfeng@...fujitsu.com>
> ---
>  block/elevator-fq.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/block/elevator-fq.c b/block/elevator-fq.c
> index d04e925..a4161c2 100644
> --- a/block/elevator-fq.c
> +++ b/block/elevator-fq.c
> @@ -131,6 +131,8 @@ static void update_min_vdisktime(struct io_service_tree *st)
>  {
>  	u64 vdisktime;
>  
> +	vdisktime = st->min_vdisktime;
> +
>  	if (st->active_entity)
>  		vdisktime = st->active_entity->vdisktime;
>  
> -- 
> 1.5.4.rc3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/