linux-kernel - Re: [GIT PULL, v4] S+core architecture (arch/score) support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1251343739.23810.24.camel@ad3ser01>
Date:	Thu, 27 Aug 2009 11:28:59 +0800
From:	Chen Liqin <liqin.chen@...plusct.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org,
	torvalds@...ux-foundation.org
Subject: Re: [GIT PULL, v4] S+core architecture (arch/score) support

On Wed, 2009-08-26 at 19:31 +0200, Arnd Bergmann wrote:
> On Wednesday 26 August 2009, Chen Liqin (Gmail) wrote:
> 
> Hi Liqin,
> 
> Similarly, the split of your patches is good for review, but it
> is useless to have 33 commits in your changelog with just the
> file names listed in the history text.

I will remove these changelog from repository.

> 
> What is missing OTOH is a description of changes you made since
> the last version you posted, which would be needed to help
> people that have already reviewed your code before.
> Also, you have dropped the descriptions of changes that I
> contributed, committing the changed files as your own. If you
> see a need to do that next time, please ask before you do it,
> or find a way to keep the original commit logs.

How can I add old commit logs to our repository?
Or add people's contribute to the log?

> What is the status of the port now? Do you have a working glibc
> and LTP test results, or are do you still need to fix more
> bugs that got introduced in the 2.6.30 port?

In fact, we still need define 
__ARCH_WANT_SYSCALL_NO_AT,
__ARCH_WANT_SYSCALL_NO_FLAGS,
__ARCH_WANT_SYSCALL_OFF_T,
__ARCH_WANT_SYSCALL_DEPRECATED
to make linux/score running, glibc and applictions 
need old syscall API.
And now it's really have some problems
in syscall interface part.

But if we use our old syscall interface replace the new one,
score platform will run well.
I am a little confused, whether or not I should commit
score code use new or old syscall part?

Best Regards
Liqin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/