linux-kernel - Re: modules: Fix build error in the !CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200908282141.31175.rusty@rustcorp.com.au>
Date:	Fri, 28 Aug 2009 21:41:30 +0930
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	James Bottomley <James.Bottomley@...senpartnership.com>,
	Helge Deller <deller@....de>
Subject: Re: modules: Fix build error in the !CONFIG_KALLSYMS case

On Fri, 28 Aug 2009 06:14:56 pm Ingo Molnar wrote:
> 
> * Linus Torvalds <torvalds@...ux-foundation.org> wrote:
> 
> > James Bottomley (1):
> >       module: workaround duplicate section names
> 
> -tip testing found that this patch breaks the build on x86 if 
> CONFIG_KALLSYMS is disabled:
> 
>  kernel/module.c: In function âload_moduleâ:
>  kernel/module.c:2367: error: âstruct moduleâ has no member named âsect_attrsâ
>  distcc[8269] ERROR: compile kernel/module.c on ph/32 failed
>  make[1]: *** [kernel/module.o] Error 1
>  make: *** [kernel] Error 2
>  make: *** Waiting for unfinished jobs....
> 
> Commit 1b364bf misses the fact that section attributes are only 
> built and dealt with if kallsyms is enabled. The patch below fixes 
> this.
> 
> ( note, technically speaking this should depend on CONFIG_SYSFS as
>   well but this patch is correct too and keeps the #ifdef less
>   intrusive - in the KALLSYMS && !SYSFS case the code is a NOP. )
> 
> Signed-off-by: Ingo Molnar <mingo@...e.hu>

Acked-by: Rusty Russell <rusty@...tcorp.com.au>

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/