linux-kernel - Re: lmb: Remove __init from lmb_end_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1251444088.20467.169.camel@pasglop>
Date:	Fri, 28 Aug 2009 17:21:28 +1000
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Linux Kernel list <linux-kernel@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	linuxppc-dev list <linuxppc-dev@...abs.org>
Subject: Re: lmb: Remove __init from lmb_end_of_DRAM()

On Thu, 2009-08-27 at 19:59 +0000, Linux Kernel Mailing List wrote:
> Gitweb:     http://git.kernel.org/linus/4f8ee2c9cc0e885d2bb50ef26db66150ab25213e
> Commit:     4f8ee2c9cc0e885d2bb50ef26db66150ab25213e
> Parent:     cf481442f2e086316ed8a1b3046f00ad23632ac4
> Author:     Benjamin Herrenschmidt <benh@...nel.crashing.org>
> AuthorDate: Thu Aug 27 17:20:30 2009 +1000
> Committer:  Linus Torvalds <torvalds@...ux-foundation.org>
> CommitDate: Thu Aug 27 12:25:26 2009 -0700
> 
>     lmb: Remove __init from lmb_end_of_DRAM()
>     
>     We call lmb_end_of_DRAM() to test whether a DMA mask is ok on a machine
>     without IOMMU, but this function is marked as __init.
>     
>     I don't think there's a clean way to get the top of RAM max_pfn doesn't
>     appear to include highmem or I missed (or we have a bug :-) so for now,
>     let's just avoid having a broken 2.6.31 by making this function
>     non-__init and we can revisit later.

And another brown paper bag for me ! Patch is fine, but doesn't do the
job because some idiot (me) didn't actually test (it looked so obvious)
and didn't notice somebody had the strange idea to also put __init on
the declaration in the .h file ! Ugh.

I'll send another patch later, have to run home now.

Cheers,
Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/