linux-kernel - Re: [PATCH mmotm] vmscan move pgdeactivate modification to shrink_active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 29 Aug 2009 19:00:47 +0900
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	Hugh Dickins <hugh.dickins@...cali.co.uk>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Johannes Weiner <hannes@...xchg.org>,
	Rik van Riel <riel@...hat.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Mel Gorman <mel@....ul.ie>, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org
Subject: Re: [PATCH mmotm] vmscan move pgdeactivate modification to 
	shrink_active_list fix

Hi Hugh

2009/8/29 Hugh Dickins <hugh.dickins@...cali.co.uk>:
> mmotm 2009-08-27-16-51 lets the OOM killer loose on my loads even
> quicker than last time: one bug fixed but another bug introduced.
> vmscan-move-pgdeactivate-modification-to-shrink_active_list.patch
> forgot to add NR_LRU_BASE to lru index to make zone_page_state index.
>
> Signed-off-by: Hugh Dickins <hugh.dickins@...cali.co.uk>

Can I use your test case?
Currently LRU_BASE is 0. it mean

LRU_BASE == NR_INACTIVE_ANON == 0
LRU_ACTIVE == NR_ACTIVE_ANON == 1

Therefore, I doubt there are another issue in current mmotm.
Can I join your strange oom fixing works?


> ---
>
>  mm/vmscan.c |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> --- mmotm/mm/vmscan.c   2009-08-28 10:07:57.000000000 +0100
> +++ linux/mm/vmscan.c   2009-08-28 18:30:33.000000000 +0100
> @@ -1381,8 +1381,10 @@ static void shrink_active_list(unsigned
>        reclaim_stat->recent_rotated[file] += nr_rotated;
>        __count_vm_events(PGDEACTIVATE, nr_deactivated);
>        __mod_zone_page_state(zone, NR_ISOLATED_ANON + file, -nr_taken);
> -       __mod_zone_page_state(zone, LRU_ACTIVE + file * LRU_FILE, nr_rotated);
> -       __mod_zone_page_state(zone, LRU_BASE + file * LRU_FILE, nr_deactivated);
> +       __mod_zone_page_state(zone, NR_ACTIVE_ANON + file * LRU_FILE,
> +                                                       nr_rotated);
> +       __mod_zone_page_state(zone, NR_INACTIVE_ANON + file * LRU_FILE,
> +                                                       nr_deactivated);
>        spin_unlock_irq(&zone->lru_lock);
>  }
>
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@...ck.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@...ck.org"> email@...ck.org </a>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/