linux-kernel - Re: [PATCH] drm: use proc_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.0908310037310.15117@skynet.skynet.ie>
Date:	Mon, 31 Aug 2009 00:38:11 +0100 (IST)
From:	Dave Airlie <airlied@...ux.ie>
To:	Alexey Dobriyan <adobriyan@...il.com>
cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm: use proc_create_data()


> Signed-off-by: Alexey Dobriyan <adobriyan@...il.com>

I pushed a slightly modified version to drm-next, it moves the
filling out of tmp before the data create.

Thanks,
Dave.

> ---
> 
>  drivers/gpu/drm/drm_proc.c |    5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> --- a/drivers/gpu/drm/drm_proc.c
> +++ b/drivers/gpu/drm/drm_proc.c
> @@ -106,7 +106,8 @@ int drm_proc_create_files(struct drm_info_list *files, int count,
>  			continue;
>  
>  		tmp = kmalloc(sizeof(struct drm_info_node), GFP_KERNEL);
> -		ent = create_proc_entry(files[i].name, S_IFREG | S_IRUGO, root);
> +		ent = proc_create_data(files[i].name, S_IRUGO, root,
> +				       &drm_proc_fops, tmp);
>  		if (!ent) {
>  			DRM_ERROR("Cannot create /proc/dri/%s/%s\n",
>  				  name, files[i].name);
> @@ -115,8 +116,6 @@ int drm_proc_create_files(struct drm_info_list *files, int count,
>  			goto fail;
>  		}
>  
> -		ent->proc_fops = &drm_proc_fops;
> -		ent->data = tmp;
>  		tmp->minor = minor;
>  		tmp->info_ent = &files[i];
>  		list_add(&(tmp->list), &(minor->proc_nodes.list));
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/