linux-kernel - Re: [PATCH] x86: detect stack protector for i386 builds on x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090830133900.GA6295@hack>
Date:	Sun, 30 Aug 2009 21:39:00 +0800
From:	Américo Wang <xiyou.wangcong@...il.com>
To:	Michal Schmidt <mschmidt@...hat.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Tejun Heo <tj@...nel.org>,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: detect stack protector for i386 builds on x86_64

On Sat, Aug 29, 2009 at 06:27:18PM +0200, Michal Schmidt wrote:
>Stack protector support was not detected when building with ARCH=i386
>on x86_64 systems:
>arch/x86/Makefile:80: stack protector enabled but no compiler support
>
>The "-m32" argument needs to be passed to the detection script.
>
>Signed-off-by: Michal Schmidt <mschmidt@...hat.com>

Looks fine.

Acked-by: WANG Cong <xiyou.wangcong@...il.com>

>
>--
>diff --git a/arch/x86/Makefile b/arch/x86/Makefile
>index 1b68659..5e7db44 100644
>--- a/arch/x86/Makefile
>+++ b/arch/x86/Makefile
>@@ -72,7 +72,7 @@ endif
> 
> ifdef CONFIG_CC_STACKPROTECTOR
> 	cc_has_sp := $(srctree)/scripts/gcc-x86_$(BITS)-has-stack-protector.sh
>-        ifeq ($(shell $(CONFIG_SHELL) $(cc_has_sp) $(CC)),y)
>+        ifeq ($(shell $(CONFIG_SHELL) $(cc_has_sp) $(CC) $(biarch)),y)
>                 stackp-y := -fstack-protector
>                 stackp-$(CONFIG_CC_STACKPROTECTOR_ALL) += -fstack-protector-all
>                 KBUILD_CFLAGS += $(stackp-y)
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@...r.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at  http://www.tux.org/lkml/

-- 
Live like a child, think like the god.
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/