linux-kernel - Re: [PATCH] gru: allocation may fail in quicktest1()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090831125059.GA31874@sgi.com>
Date:	Mon, 31 Aug 2009 07:50:59 -0500
From:	Jack Steiner <steiner@....com>
To:	Roel Kluin <roel.kluin@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gru: allocation may fail in quicktest1()

On Mon, Aug 31, 2009 at 10:32:15AM +0200, Roel Kluin wrote:
> The allocation may fail.
> 
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>

Acked-by: Jack Steiner <steiner@....com>

> ---
> diff --git a/drivers/misc/sgi-gru/grukservices.c b/drivers/misc/sgi-gru/grukservices.c
> index 79689b1..766e21e 100644
> --- a/drivers/misc/sgi-gru/grukservices.c
> +++ b/drivers/misc/sgi-gru/grukservices.c
> @@ -937,6 +937,8 @@ static int quicktest1(unsigned long arg)
>  
>  	/* Need  1K cacheline aligned that does not cross page boundary */
>  	p = kmalloc(4096, 0);
> +	if (p == NULL)
> +		return -ENOMEM;
>  	mq = ALIGNUP(p, 1024);
>  	memset(mes, 0xee, sizeof(mes));
>  	dw = mq;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/