linux-kernel - Re: [PATCH] Fix proc_file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090831171956.GA3036@x200.localdomain>
Date:	Mon, 31 Aug 2009 21:19:56 +0400
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Stefani Seibold <stefani@...bold.net>,
	Christoph Hellwig <hch@...radead.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] Fix proc_file_write missing ppos update

On Mon, Aug 31, 2009 at 05:44:52PM +0200, Arnd Bergmann wrote:
> On Monday 31 August 2009, Alexey Dobriyan wrote:
> > Out-of-tree argument means almost nothing.
> > 
> > ...
> >
> > You'd better start converting to struct file_operations::write now.
> 
> Maybe a purely mechanical conversion to file_operations would be a nice first
> step, just so we can remove read_proc and write_proc? Taking scsi_proc.c
> as an example, this should be really straightforward and lets us get
> rid of the write_proc and read_proc callbacks from proc_dir_entry without
> having to rewrite all the remaining drivers that use it.
> 
> Obviously, someone who understands the specific driver code better should
> then clean up the code by converting to seq_file operations or something
> else that is appropriate there.

I don't like any churn in that area. Everything is ready for ->proc_fops usage.
So we should simply convert users away.
Actually most of SCSI and IDE is already done, just wasn't sent yet.

After conversion, ->read_proc, ->write_proc, create_proc_read_entry(),
create_proc_entry() will become deprecated for a while, then gone.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/