linux-kernel - Re: [PATCH 1/8] writeback: move super_block argument to struct writeback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090901115551.GA727@mit.edu>
Date:	Tue, 1 Sep 2009 07:55:51 -0400
From:	Theodore Tso <tytso@....edu>
To:	Jens Axboe <jens.axboe@...cle.com>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	chris.mason@...cle.com, david@...morbit.com, hch@...radead.org,
	akpm@...ux-foundation.org, jack@...e.cz
Subject: Re: [PATCH 1/8] writeback: move super_block argument to struct
	writeback_control

On Tue, Sep 01, 2009 at 01:18:59PM +0200, Jens Axboe wrote:
> Signed-off-by: Jens Axboe <jens.axboe@...cle.com>
> ---
>  fs/ubifs/super.c                 |    3 ++-
>  include/linux/fs.h               |    3 +--
>
> diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
> @@ -462,7 +463,7 @@ static int ubifs_sync_fs(struct super_block *sb, int wait)
>  	 * the user be able to get more accurate results of 'statfs()' after
>  	 * they synchronize the file system.
>  	 */
> -	generic_sync_sb_inodes(sb, &wbc);
> +	generic_sync_sb_inodes(&wbc);
>  
>  	/*
>  	 * Synchronize write buffers, because 'ubifs_run_commit()' does not

I just tried compiling per-bdi v15 against the latest git HEAD, and
the compilation failed:

fs/ubifs/super.c: In function ‘ubifs_sync_fs’:
fs/ubifs/super.c:465: warning: passing argument 1 of ‘generic_sync_sb_inodes’ from incompatible pointer type
fs/ubifs/super.c:465: error: too many arguments to function ‘generic_sync_sb_inodes’

Looks like the latest version of fs/ubifs/super.c added a call to
generic_sync_sb_inodes that needs to be fixed up.  Line 465:

	generic_sync_sb_inodes(sb, &wbc);

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/