linux-kernel - Re: [PATCH 1/3] tracing: make splice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090901223659.GB6108@nowhere>
Date:	Wed, 2 Sep 2009 00:37:01 +0200
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Lai Jiangshan <laijs@...fujitsu.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Steven Rostedt <rostedt@...dmis.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] tracing: make splice_read work when data is
	sufficient

On Tue, Sep 01, 2009 at 08:29:53PM +0800, Lai Jiangshan wrote:
> Frederic Weisbecker wrote:
> >>  	 */
> >> +	cpu_buffer->reader_page->read = 0;
> > 
> > 
> > 
> > Wasn't this reset done before?
> > 
> > 
> 
> This is not reset. It is still used just before this line.



Yeah but after that it's not used anymore because this page
won't anymore be used as a reader page but will be integrated
as a writable ring buffer page.

One day it may be reused as a reader page still, but before
any use, rb_reset_reader_page() will be called to reset this offset.

So I just don't understand why you need to do that.


 
> > 
> > 
> > Reviewed-by: Frederic Weisbecker <fweisbec@...il.com>
> > 
> > 
> 
> Ingo, Could you apply this patch and fix the bug?
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/