linux-kernel - Re: [PATCH 1/6] SECURITY: selinux, fix update_rlimit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A9CBD22.1050401@gmail.com>
Date:	Tue, 01 Sep 2009 08:20:18 +0200
From:	Jiri Slaby <jirislaby@...il.com>
To:	James Morris <jmorris@...ei.org>
CC:	Andrew Morton <akpm@...ux-foundation.org>, mingo@...hat.com,
	oleg@...hat.com, linux-kernel@...r.kernel.org,
	Stephen Smalley <sds@...ho.nsa.gov>,
	Eric Paris <eparis@...isplace.org>,
	David Howells <dhowells@...hat.com>,
	linux-security-module@...r.kernel.org,
	Frank Mayhar <fmayhar@...gle.com>
Subject: Re: [PATCH 1/6] SECURITY: selinux, fix update_rlimit_cpu parameter

On 09/01/2009 12:22 AM, James Morris wrote:
> On Mon, 31 Aug 2009, Jiri Slaby wrote:
> 
> [added lsm list]
> 
>> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
>> index cf41988..496e626 100644
>> --- a/security/selinux/hooks.c
>> +++ b/security/selinux/hooks.c
>> @@ -2360,7 +2360,7 @@ static void selinux_bprm_committing_creds(struct linux_binprm *bprm)
>>  			initrlim = init_task.signal->rlim + i;
>>  			rlim->rlim_cur = min(rlim->rlim_max, initrlim->rlim_cur);
>>  		}
>> -		update_rlimit_cpu(rlim->rlim_cur);
>> +		update_rlimit_cpu(current->signal->rlim[RLIMIT_CPU].rlim_cur);
> 
> This doesn't look correct to me: the original code determines 
> rlim->rlim_cur and then updates current to that.  With your change, this 
> value is not used.

No, the for loop is to alter all limits according to the init limits.

update_rlimit_cpu is called for RLIMIT_CPU to annotate scheduler about
CPU time changes (if any).

BTW this was introduced by f06febc96ba8e0af80bcc3eaec0a109e88275fac
(timers: fix itimer/many thread hang).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/