[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <4A9CCE7C.3060702@in.ibm.com>
Date: Tue, 01 Sep 2009 13:04:20 +0530
From: Suzuki Poulose <suzuki@...ibm.com>
To: akpm@...ux-foundation.org
CC: lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Fix compat_sys_utimensat
Suzuki Poulose wrote:
>
> Hi,
>
> The compat_utimensat syscall does not ignore tv_sec field when tv_nsec
> is set to UTIME_OMIT/UTIME_NOW and returns -EINVAL.
mjs22lp5:~ # cat utimensat-test.c
#define _GNU_SOURCE
#define _ATFILE_SOURCE
#include <stdio.h>
#include <fcntl.h>
#include <unistd.h>
#include <sys/stat.h>
#include <stdlib.h>
main(int argc, char *argv[])
{
struct timespec ts[2];
struct timespec *tsp;
if (argc < 2) {
fprintf(stderr, "Usage : %s filename\n", argv[0]);
exit (-1);
}
ts[0].tv_nsec = ts[1].tv_nsec = UTIME_NOW;
ts[0].tv_sec = ts[1].tv_sec = 1;
tsp = ts;
if (utimensat(AT_FDCWD, argv[1],tsp,0) == -1)
perror("utimensat");
else
fprintf(stdout, "utimensat success\n");
return 0;
}
mjs22lp5:~ # cc -m64 utimensat-test.c -o utimensat_test64
mjs22lp5:~ # cc -m32 utimensat-test.c -o utimensat_test32
mjs22lp5:~ # ./utimensat_test32 /tmp/utimensat_test
utimensat: Invalid argument
mjs22lp5:~ # ./utimensat_test64 /tmp/utimensat_test
utimensat success
mjs22lp5:~ # uname -r
2.6.31-rc8
>
> This problem was revealed with the utimensat_tests from LTP.
>
> The utimensat() syscall works fine.
>
> Attaching a patch for the issue. The patch has been tested and verified
> to fix the issue.
With the patch :
mjs22lp5:~ # ./utimensat_test64 /tmp/utimensat_test
utimensat success
mjs22lp5:~ # ./utimensat_test32 /tmp/utimensat_test
utimensat success
mjs22lp5:~ # uname -r
2.6.31-rc8utimensat
>
> Please apply.
>
> Thanks,
>
> Suzuki
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists