linux-kernel - Re: [PATCH V6 2/2] introduce ACPI ALS device driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 1 Sep 2009 10:44:01 +0200
From:	Pavel Machek <pavel@....cz>
To:	Zhang Rui <rui.zhang@...el.com>
Cc:	Len Brown <lenb@...nel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-acpi <linux-acpi@...r.kernel.org>,
	Greg KH <greg@...ah.com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>
Subject: Re: [PATCH V6 2/2] introduce ACPI ALS device driver

On Tue 2009-09-01 16:39:36, Zhang Rui wrote:
> On Tue, 2009-09-01 at 16:13 +0800, Pavel Machek wrote:
> > Hi!
> > 
> > > ACPI spec defines ACPI Ambient Light Sensor device (hid ACPI0008),
> > > which provides a standard interface by which the OS may query properties
> > > of the ambient light environment the system is currently operating in,
> > > as well as the ability to detect meaningful changes in these values when
> > > the environment changes.
> > 
> > > +struct acpi_als {
> > > +	struct acpi_device *device;
> > > +	struct als_device *als_sys;
> > > +	int illuminance;
> > > +	int chromaticity;
> > > +	int temperature;
> > > +	int polling;
> > > +	int count;
> > > +	struct als_mapping *mappings;
> > > +};
> > 
> > chromaticity is write-only variable.
> 
> >  I believe you can drop it and
> > associted code.
> > 
> > temperature ditto. Drop from this version?
> > 
> > polling ditto. Drop from this version?
> > 
> ???color temperature, chromaticity and polling are three optional features
> defined in the ACPI spec, which are not supported yet in the ACPI ALS
> driver right now.
> 
> I think it's okay to add the code first and then generate some
> incremental patches to enable these features once we found such kind of
> platforms.

I'd avoid adding dead code to ease review etc... You can add it back
easily when it actually has users...
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/