linux-kernel - Re: [PATCH] pagemap: document KPF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090901075850.GB1446@localhost>
Date:	Tue, 1 Sep 2009 15:58:50 +0800
From:	Wu Fengguang <fengguang.wu@...el.com>
To:	Chris Wright <chrisw@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Josh Triplett <josh@...htriplett.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Andi Kleen <andi@...stfloor.org>,
	Nick Piggin <nickpiggin@...oo.com.au>,
	Christoph Lameter <cl@...ux-foundation.org>,
	Hugh Dickins <hugh.dickins@...cali.co.uk>,
	Izik Eidus <ieidus@...hat.com>
Subject: Re: [PATCH] pagemap: document KPF_KSM and show it in page-types

On Tue, Sep 01, 2009 at 12:41:51AM +0800, Chris Wright wrote:
> * Wu Fengguang (fengguang.wu@...el.com) wrote:
> > It indicates to the system admin that processes mapping such pages may be
> > eating less physical memory than the reported numbers by legacy tools.
> > 
> > CC: Hugh Dickins <hugh.dickins@...cali.co.uk>
> > CC: Chris Wright <chrisw@...hat.com>
> > CC: Izik Eidus <ieidus@...hat.com>
> > Signed-off-by: Wu Fengguang <fengguang.wu@...el.com>
> 
> Acked-by: Chris Wright <chrisw@...hat.com>

Thanks.

> > --- linux-mm.orig/tools/vm/page-types.c	2009-08-31 15:00:24.000000000 +0800
> > +++ linux-mm/tools/vm/page-types.c	2009-08-31 15:02:10.000000000 +0800
> > @@ -49,6 +49,7 @@
> >  #define KPF_UNEVICTABLE		18
> >  #define KPF_HWPOISON		19
> >  #define KPF_NOPAGE		20
> > +#define KPF_KSM			21
> 
> Doesn't this highlight the trouble w/ maintaining two copies of same info?

Yes, I even had patch to move these numbers to page-flags.h.
however given that we have to update the flag name strings anyway,
this is not a big extra burden?

Thanks,
Fengguang

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/