linux-kernel - Re: [PATCH, v2] isdn: Fix stack corruption in isdnloop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090902061439.6c60124c@infradead.org>
Date:	Wed, 2 Sep 2009 06:14:39 -0700
From:	Arjan van de Ven <arjan@...radead.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	linux-kernel@...r.kernel.org, Karsten Keil <isdn@...ux-pingi.de>,
	isdn4linux@...tserv.isdn4linux.de,
	Andrew Morton <akpm@...ux-foundation.org>, tj@...e.hu
Subject: Re: [PATCH, v2] isdn: Fix stack corruption in isdnloop_init()

On Wed, 2 Sep 2009 15:03:36 +0200
Ingo Molnar <mingo@...e.hu> wrote:

> 
> [ v2: use strlen instead of sizeof. ]
> 
> diff --git a/drivers/isdn/isdnloop/isdnloop.c
> b/drivers/isdn/isdnloop/isdnloop.c index a335c85..0c8d8cb 100644
> --- a/drivers/isdn/isdnloop/isdnloop.c
> +++ b/drivers/isdn/isdnloop/isdnloop.c
> @@ -1494,7 +1494,7 @@ static int __init
>  isdnloop_init(void)
>  {
>  	char *p;
> -	char rev[10];
> +	char rev[strlen(revision)+1];
>  
>  	if ((p = strchr(revision, ':'))) {
>  		strcpy(rev, p + 1);

now it;s a runtime variable sized array.
NotNice(tm)


-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/