linux-kernel - Re: [PATCH 2/2] ARM: copy_page.S: take into account the size of the cache line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090902132423.GA12595@n2100.arm.linux.org.uk>
Date:	Wed, 2 Sep 2009 14:24:23 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	"Kirill A. Shutemov" <kirill@...temov.name>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Bityutskiy Artem <Artem.Bityutskiy@...ia.com>,
	Siarhei Siamashka <siarhei.siamashka@...ia.com>,
	Moiseichuk Leonid <leonid.moiseichuk@...ia.com>,
	Koskinen Aaro <aaro.koskinen@...ia.com>
Subject: Re: [PATCH 2/2] ARM: copy_page.S: take into account the size of
	the cache line

On Wed, Sep 02, 2009 at 07:11:53PM +0300, Kirill A. Shutemov wrote:
>  ENTRY(copy_page)
>  		stmfd	sp!, {r4, lr}			@	2
>  	PLD(	pld	[r1, #0]		)
> -	PLD(	pld	[r1, #32]		)
> +	PLD(	pld	[r1, #L1_CACHE_BYTES]		)
>  		mov	r2, #COPY_COUNT			@	1
>  		ldmia	r1!, {r3, r4, ip, lr}		@	4+1
> -1:	PLD(	pld	[r1, #64]		)
> -	PLD(	pld	[r1, #96]		)
> -2:		stmia	r0!, {r3, r4, ip, lr}		@	4
> -		ldmia	r1!, {r3, r4, ip, lr}		@	4+1
> -		stmia	r0!, {r3, r4, ip, lr}		@	4
> -		ldmia	r1!, {r3, r4, ip, lr}		@	4+1
> +1:	PLD(	pld	[r1, #(2*L1_CACHE_BYTES)])
> +	PLD(	pld	[r1, #(3*L1_CACHE_BYTES)])

I really hate unnecessary parens - please remove them, and put a space
each side of the '*'.

> +2:
> +	.rept	(2 * (L1_CACHE_BYTES) / 16 - 1)

Parens are not required around L1_CACHE_BYTES either.

Other than that, patch is fine.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/