linux-kernel - Re: [patch 1/2 -mm] flex_array: introduce DEFINE_FLEX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.1.00.0909021148420.9971@chino.kir.corp.google.com>
Date:	Wed, 2 Sep 2009 11:51:06 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Dave Hansen <dave@...ux.vnet.ibm.com>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [patch 1/2 -mm] flex_array: introduce DEFINE_FLEX_ARRAY

On Wed, 2 Sep 2009, Dave Hansen wrote:

> This all looks pretty good.  The only issue is that the macro name
> lengths have gotten a bit out of hand.  
> 
> For instance.  This:
> 
> #define FLEX_ARRAY_ELEMENTS_PER_PART(size)                             \
>        (FLEX_ARRAY_PART_SIZE / size)
> 
> ends up being longer in practice than just open-coding the operation:
> 
> 	FLEX_ARRAY_ELEMENTS_PER_PART(fa->element_size)                      
> 
> vs.
> 
> 	(FLEX_ARRAY_PART_SIZE / fa->element_size)
> 
> and the length also ends up making for a couple of pretty ugly line
> wraps.
> 

Agreed, it's difficult to shorten because they need to be prefixed with 
FLEX_ARRAY_ since they are global macros now that they've been included in 
linux/flex_array.h.

> Otherwise, this is fine with me.
> 
> Acked-by: Dave Hansen <dave@...ux.vnet.ibm.com>
> 

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/