linux-kernel - RE: [PATCH 1/14] bfa: Brocade BFA FC SCSI driver (bfad)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 2 Sep 2009 13:02:07 -0700
From:	Jing Huang <huangj@...cade.COM>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	"James.Bottomley@...senPartnership.com" 
	<James.Bottomley@...senPartnership.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	Ramkumar Vadivelu <rvadivel@...cade.COM>,
	Vinodh Ravindran <vravindr@...cade.COM>
Subject: RE: [PATCH 1/14] bfa: Brocade BFA FC SCSI driver (bfad)

> These patches seem to have been posted a lot of times.  Is anyone
> paying attention?
> 
> > +BFA_TRC_FILE(LDRV, BFAD);
> > +
> > +static DEFINE_MUTEX(bfad_mutex);
> > +int bfad_scan_done;
> > +
> > +LIST_HEAD(bfad_list);
> > +
> > +static int      bfad_inst;
> > +int             supported_fc4s;
> > +
> > +char           *host_name;
> > +char           *os_name;
> > +char           *os_patch;
> > +int             num_rports;
> > +int             num_ios;
> > +int             num_tms;
> > +int             num_fcxps;
> > +int             num_ufbufs;
> > +int             reqq_size;
> > +int             rspq_size;
> > +int             num_sgpgs;
> > +int             rport_del_timeout = BFA_FCS_RPORT_DEF_DEL_TIMEOUT;
> > +int             bfa_lun_queue_depth = BFAD_LUN_QUEUE_DEPTH;
> > +int             bfa_io_max_sge = BFAD_IO_MAX_SGE;
> > +int             log_level = BFA_LOG_WARNING;
> > +int             ioc_auto_recover = BFA_TRUE;
> > +int             ipfc_enable = BFA_FALSE;
> > +int             ipfc_mtu = -1;
> > +int             linkup_delay = -1;
> 
> eek.  These are all kernel-wide global symbols and many of them are
> very inappropriately named.  They should either be made static or given
> a subsystem-specific prefix such as "bfad_".
> 

Thanks Andrew. I will fix this and resubmit.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/