[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <661de9470909021302ge86d01s5d107dc2b5cffbc5@mail.gmail.com>
Date: Thu, 3 Sep 2009 01:32:24 +0530
From: Balbir Singh <balbir@...ux.vnet.ibm.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
Cc: Ryo Tsuruta <ryov@...inux.co.jp>, linux-kernel@...r.kernel.org,
dm-devel@...hat.com, containers@...ts.linux-foundation.org,
virtualization@...ts.linux-foundation.org,
xen-devel@...ts.xensource.com, linux-mm@...ck.org
Subject: Re: a room for blkio-cgroup in struct page_cgroup
2009/9/2 KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>:
> Ryo Tsuruta wrote:
>> Hi Kamezawa-san,
>>
>> As you wrote before (http://lkml.org/lkml/2009/7/22/65)
>>> To be honest, what I expected in these days for people of blockio
>>> cgroup is like following for getting room for themselves.
>> <<snip>>
>>> --- mmotm-2.6.31-Jul16.orig/include/linux/page_cgroup.h
>>> +++ mmotm-2.6.31-Jul16/include/linux/page_cgroup.h
>>> @@ -13,7 +13,7 @@
>>> struct page_cgroup {
>>> unsigned long flags;
>>> struct mem_cgroup *mem_cgroup;
>>> - struct page *page;
>>> + /* block io tracking will use extra unsigned long bytes */
>>> struct list_head lru; /* per cgroup LRU list */
>>> };
>>
>> Have you already added a room for blkio_cgroup in struct page_cgroup?
> No.
>
The diff above is unclear, are you removing struct page from page_cgroup?
Balbir Singh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists