linux-kernel - RE: [RFC PATCH] Add TRACE_IRQFLAGS_SUPPORT, LOCKDEP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57C9024A16AD2D4C97DC78E552063EA3E038DE7E@orsmsx505.amr.corp.intel.com>
Date:	Wed, 2 Sep 2009 16:27:15 -0700
From:	"Luck, Tony" <tony.luck@...el.com>
To:	Ingo Molnar <mingo@...e.hu>, Luming Yu <luming.yu@...il.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
CC:	Christoph Hellwig <hch@...radead.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"linux-ia64@...r.kernel.org" <linux-ia64@...r.kernel.org>,
	"Yu, Fenghua" <fenghua.yu@...el.com>,
	Felix Blyakher <felixb@....com>,
	"Li, Shaohua" <shaohua.li@...el.com>, Bob Picco <bob.picco@...com>
Subject: RE: [RFC PATCH] Add TRACE_IRQFLAGS_SUPPORT, LOCKDEP_SUPPORT then
	enable ftrace for ia64

>> diff -BruN linux-2.6.31-rc6/arch/ia64/include/asm/page.h
>> linux-2.6.31-rc6-lockdep/arch/ia64/include/asm/page.h
>> --- linux-2.6.31-rc6/arch/ia64/include/asm/page.h	2009-08-13
>> 15:43:34.000000000 -0700
>> +++ linux-2.6.31-rc6-lockdep/arch/ia64/include/asm/page.h	2009-08-23
>> 18:59:00.000000000 -0700
>> @@ -41,7 +41,7 @@
>>  #define PAGE_SIZE		(__IA64_UL_CONST(1) << PAGE_SHIFT)
>>  #define PAGE_MASK		(~(PAGE_SIZE - 1))
>> 
>> -#define PERCPU_PAGE_SHIFT	16	/* log2() of max. size of per-CPU area */
>> +#define PERCPU_PAGE_SHIFT	20	/*16 log2() of max. size of per-CPU area */
>>  #define PERCPU_PAGE_SIZE	(__IA64_UL_CONST(1) << PERCPU_PAGE_SHIFT)
>
> Why was this seemingly unrelated change done in a lockdep patch?

IIRC it is because the lockdep code needs a lot more percpu memory than the
64K that ia64 allocates.

But I think that I'd prefer to only allocate the extra space when it
is needed:

#ifdef CONFIG_LOCKDEP
#define PERCPU_PAGE_SHIFT 20 /* Need a Megabyte for lockdep */
#else
#define PERCPU_PAGE_SHIFT 16 /* 64K should be enough for normal use */
#endif

-Tony


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/