linux-kernel - Re: [RFC v6][PATCH 1/4] intel_txt: Intel(R) TXT boot support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 03 Sep 2009 13:28:34 +0100
From:	David Woodhouse <dwmw2@...radead.org>
To:	joseph.cihula@...el.com
Cc:	linux-kernel@...r.kernel.org, mingo@...e.hu, arjan@...ux.intel.com,
	hpa@...or.com, andi@...stfloor.org, chrisw@...s-sol.org,
	jmorris@...ei.org, jbeulich@...ell.com, peterm@...hat.com,
	gang.wei@...el.com, shane.wang@...el.com
Subject: Re: [RFC v6][PATCH 1/4] intel_txt: Intel(R) TXT boot support

On Tue, 2009-06-30 at 19:30 -0700, Joseph Cihula wrote:
> 
> +int tboot_force_iommu(void)
> +{
> +       if (!tboot_enabled())
> +               return 0;
> +
> +       if (no_iommu || swiotlb || dmar_disabled)
> +               pr_warning("Forcing Intel-IOMMU to enabled\n");
> +
> +       dmar_disabled = 0;
> +#ifdef CONFIG_SWIOTLB
> +       swiotlb = 0;
> +#endif
> +       no_iommu = 0;
> +
> +       return 1;
> +}

Ick. The logic for selecting which IOMMU is used is convoluted enough
already, without adding this here.

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@...el.com                              Intel Corporation

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/