linux-kernel - Re: a room for blkio-cgroup in struct page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090903.140932.189713001.ryov@valinux.co.jp>
Date:	Thu, 03 Sep 2009 14:09:32 +0900 (JST)
From:	Ryo Tsuruta <ryov@...inux.co.jp>
To:	kamezawa.hiroyu@...fujitsu.com
Cc:	balbir@...ux.vnet.ibm.com, linux-kernel@...r.kernel.org,
	dm-devel@...hat.com, containers@...ts.linux-foundation.org,
	virtualization@...ts.linux-foundation.org,
	xen-devel@...ts.xensource.com, linux-mm@...ck.org
Subject: Re: a room for blkio-cgroup in struct page_cgroup

Hi Kamezawa-san,

"KAMEZAWA Hiroyuki" <kamezawa.hiroyu@...fujitsu.com> wrote:
> Ryo Tsuruta wrote:
> > Hi Kamezawa-san,
> >
> > As you wrote before (http://lkml.org/lkml/2009/7/22/65)
> >> To be honest, what I expected in these days for people of blockio
> >> cgroup is like following for getting room for themselves.
> > <<snip>>
> >> --- mmotm-2.6.31-Jul16.orig/include/linux/page_cgroup.h
> >> +++ mmotm-2.6.31-Jul16/include/linux/page_cgroup.h
> >> @@ -13,7 +13,7 @@
> >>  struct page_cgroup {
> >>       unsigned long flags;
> >>       struct mem_cgroup *mem_cgroup;
> >> -     struct page *page;
> >> +     /* block io tracking will use extra unsigned long bytes */
> >>       struct list_head lru;       /* per cgroup LRU list */
> >> };
> >
> > Have you already added a room for blkio_cgroup in struct page_cgroup?
> No.
> 
> > If not, I would like you to apply the above change to mmotm.
> >
> Plz wait until October. We're deadly busy and some amount of more important
> patches are piled up in front of us. I have no objections if you add
> a pointer or id  because I know I can reduce 8(4)bytes later.
> Just add (a small) member for a while and ignore page_cgroup's size.
> I'll fix later.

Thank you very much, but I've already added unsigned long member in the
last posted patch...

> > The latest blkio-cgroup has reflected the comments you pointed out.
> > I would also like you to give me any comments on it and consider
> > merging blkio-cgroup to mmotm.
> >
> BTW, do you all have cosensus about implementation ?

Not yet, it is under discussion now.

Thanks,
Ryo Tsuruta
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/