linux-kernel - Re: [PATCH 1/5] kmemleak: use bool for true/false questions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <84144f020909022302m2ac62f55j63e19ddac8bc511c@mail.gmail.com>
Date:	Thu, 3 Sep 2009 09:02:09 +0300
From:	Pekka Enberg <penberg@...helsinki.fi>
To:	"Luis R. Rodriguez" <lrodriguez@...eros.com>
Cc:	catalin.marinas@....com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] kmemleak: use bool for true/false questions

On Thu, Sep 3, 2009 at 4:40 AM, Luis R. Rodriguez<lrodriguez@...eros.com> wrote:
> Signed-off-by: Luis R. Rodriguez <lrodriguez@...eros.com>

Acked-by: Pekka Enberg <penberg@...helsinki.fi>

> ---
>  mm/kmemleak.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/mm/kmemleak.c b/mm/kmemleak.c
> index 4872673..c6e71bb 100644
> --- a/mm/kmemleak.c
> +++ b/mm/kmemleak.c
> @@ -264,17 +264,17 @@ static void kmemleak_disable(void);
>  * Newly created objects don't have any color assigned (object->count == -1)
>  * before the next memory scan when they become white.
>  */
> -static int color_white(const struct kmemleak_object *object)
> +static bool color_white(const struct kmemleak_object *object)
>  {
>        return object->count != -1 && object->count < object->min_count;
>  }
>
> -static int color_gray(const struct kmemleak_object *object)
> +static bool color_gray(const struct kmemleak_object *object)
>  {
>        return object->min_count != -1 && object->count >= object->min_count;
>  }
>
> -static int color_black(const struct kmemleak_object *object)
> +static bool color_black(const struct kmemleak_object *object)
>  {
>        return object->min_count == -1;
>  }
> @@ -284,7 +284,7 @@ static int color_black(const struct kmemleak_object *object)
>  * not be deleted and have a minimum age to avoid false positives caused by
>  * pointers temporarily stored in CPU registers.
>  */
> -static int unreferenced_object(struct kmemleak_object *object)
> +static bool unreferenced_object(struct kmemleak_object *object)
>  {
>        return (object->flags & OBJECT_ALLOCATED) && color_white(object) &&
>                time_before_eq(object->jiffies + jiffies_min_age,
> --
> 1.6.3.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/