[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9b2b86520909030135v73319621g39225ef5191a28f0@mail.gmail.com>
Date: Thu, 3 Sep 2009 09:35:52 +0100
From: Alan Jenkins <sourcejedi.lkml@...glemail.com>
To: Zhang Rui <rui.zhang@...el.com>
Cc: Len Brown <lenb@...nel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
linux-acpi <linux-acpi@...r.kernel.org>,
Greg KH <greg@...ah.com>, Pavel Machek <pavel@....cz>
Subject: Re: [PATCH V6 1/2] introduce ALS sysfs class
On 9/3/09, Zhang Rui <rui.zhang@...el.com> wrote:
> On Thu, 2009-09-03 at 03:22 +0800, Alan Jenkins wrote:
>> On 9/1/09, Zhang Rui <rui.zhang@...el.com> wrote:
>> >
>> > Introduce ALS sysfs class.
>> >
>> > ALS sysfs class provides a standard sysfs interface for
>> > Ambient Light Sensor devices.
>> >
>> > please read Documentation/ABI/testing/sysfs-class-als for
>> > detailed sysfs designs.
>> >
>> > CC: Pavel Machek <pavel@....cz>
>> > Acked-by: Greg Kroah-Hartman <gregkh@...e.de>
>> > Signed-off-by: Zhang Rui <rui.zhang@...el.com>
>> > ---
>>
>> > +++ linux-2.6/drivers/als/Kconfig
>> > @@ -0,0 +1,10 @@
>> > +#
>> > +# Ambient Light Sensor sysfs device configuration
>> > +#
>> > +
>> > +menuconfig ALS
>> > + tristate "Ambient Light Sensor sysfs device"
>> > + help
>> > + This framework provides a generic sysfs interface for
>> > + Ambient Light Sensor devices.
>> > + If you want this support, you should say Y or M here.
>>
>> Gratuitous nitpick:
>> Can this option be made non-visible (or hidden behind CONFIG_EMBEDDED)?
>>
>> Maybe you copied the pattern of the thermal sysfs interface - but the
>> ACPI thermal driver is useful to keep your computer cool even without
>> the sysfs interface. ALS drivers are useless without the sysfs
>> interface, no?
>>
> ACPI ALS device driver is the first user of this sysfs class.
> I think there will be more native ALS device drivers in the future,
> which locate at drivers/als/ and depends on CONFIG_ALS.
>
> thanks,
> rui
Oh! So it may become a menu like e.g. hwmon.
Thanks for the explanation
Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists