linux-kernel - [PATCH] ncpfs: fix selection of NLS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <4AA0E50702000078000136D8@vpn.id2.novell.com>
Date:	Fri, 04 Sep 2009 08:59:35 +0100
From:	"Jan Beulich" <JBeulich@...ell.com>
To:	<vandrove@...cvut.cz>
Cc:	<linware@...cvut.cz>, <linux-kernel@...r.kernel.org>
Subject: [PATCH] ncpfs: fix selection of NLS

In order for nls_base to really be compilable as a module, the select
from ncpfs needs to be corrected: Boolean sub-options of tristate
options selecting another tristate option should not do the select
themselves, as that forces the selected option to Y. Instead, a
conditional select in the base tristate option is needed.

Signed-off-by: Jan Beulich <jbeulich@...ell.com>

---
 fs/ncpfs/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.31-rc8/fs/ncpfs/Kconfig	2009-03-24 00:12:14.000000000 +0100
+++ 2.6.31-rc8-ncpfs-nls-select/fs/ncpfs/Kconfig	2009-09-02 13:56:05.000000000 +0200
@@ -4,6 +4,7 @@
 config NCP_FS
 	tristate "NCP file system support (to mount NetWare volumes)"
 	depends on IPX!=n || INET
+	select NLS if NCPFS_NLS
 	help
 	  NCP (NetWare Core Protocol) is a protocol that runs over IPX and is
 	  used by Novell NetWare clients to talk to file servers.  It is to
@@ -86,7 +87,6 @@ config NCPFS_SMALLDOS
 config NCPFS_NLS
 	bool "Use Native Language Support"
 	depends on NCP_FS
-	select NLS
 	help
 	  Allows you to use codepages and I/O charsets for file name
 	  translation between the server file system and input/output. This



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/