linux-kernel - [PATCH] x86: increase timeout for EHCI debug port reset completion in early printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <4AA0E85D02000078000136F9@vpn.id2.novell.com>
Date:	Fri, 04 Sep 2009 09:13:49 +0100
From:	"Jan Beulich" <JBeulich@...ell.com>
To:	<mingo@...e.hu>, <tglx@...utronix.de>, <hpa@...or.com>
Cc:	<yhlu.kernel@...il.com>, <linux-kernel@...r.kernel.org>
Subject: [PATCH] x86: increase timeout for EHCI debug port reset
	 completion in early printk

On one of my systems, several thousand iterations are needed before
CMD_RESET can be observed clear after setting it. Using a much higher
value here obviously cannot hurt.

Signed-off-by: Jan Beulich <jbeulich@...ell.com>
Cc: Yinghai Lu <yhlu.kernel@...il.com>

---
 arch/x86/kernel/early_printk.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.31-rc8/arch/x86/kernel/early_printk.c	2009-06-10 05:05:27.000000000 +0200
+++ 2.6.31-rc8-x86-earlyprintk-dbgp-reset/arch/x86/kernel/early_printk.c	2009-09-02 12:13:01.000000000 +0200
@@ -624,7 +624,7 @@ try_next_port:
 		return -1;
 	}
 
-	loop = 10;
+	loop = 100000;
 	/* Reset the EHCI controller */
 	cmd = readl(&ehci_regs->command);
 	cmd |= CMD_RESET;



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/