linux-kernel - Re: [PATCH 1/1] exec: do not sleep in TASK_TRACED under ->cred_guard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <32710.1252075656@redhat.com>
Date:	Fri, 04 Sep 2009 15:47:36 +0100
From:	David Howells <dhowells@...hat.com>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	dhowells@...hat.com, Roland McGrath <roland@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	James Morris <jmorris@...ei.org>,
	Tom Horsley <tom.horsley@....net>,
	linux-kernel@...r.kernel.org, stable@...nel.org
Subject: Re: [PATCH 1/1] exec: do not sleep in TASK_TRACED under ->cred_guard_mutex

Oleg Nesterov <oleg@...hat.com> wrote:

> 	- install_exec_creds() drops the mutex after commit_creds(),
> 	  and thus before tracehook_report_exec()->ptrace_stop().

Thanks!

> -
> -	/* cred_guard_mutex must be held at least to this point to prevent
> -	 * ptrace_attach() from altering our determination of the task's
> -	 * credentials; any time after this it may be unlocked */
> -

Why are you removing this comment, btw?  In what way does your patch
invalidate it?

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/