linux-kernel - Re: [PATCH 0/3] tracing - adding common method for reading/parsing user input

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090905011525.GA2513@jolsa.redhat.com>
Date:	Sat, 5 Sep 2009 03:15:25 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	mingo@...e.hu, linux-kernel@...r.kernel.org,
	Frederic Weisbecker <fweisbec@...il.com>
Subject: Re: [PATCH 0/3] tracing - adding common method for reading/parsing
	user input

On Fri, Sep 04, 2009 at 09:51:29AM -0400, Steven Rostedt wrote:
> 
> On Fri, 2009-09-04 at 15:31 +0200, jolsa@...hat.com wrote:
> > As 3 different places for 4 user input files were using the same way
> > of reading and parsing user's input, I made one common routine to be
> > used. 
> > 
> > The mentioned files are:
> > 	set_graph_function
> > 	set_event
> > 	set_ftrace_filter
> > 	set_ftrace_notrace
> > 
> 
> Hi Jolsa,
> 
> I'll take a look at these. I know there's duplicate code that I even
> wrote a "generic" handler for others to use, that basically got a NAK
> from Andrew Morton. I probably could have put it into the ftrace code
> directly, but never did so.
> 
> It will be interesting to look at your patches, especially when those
> functions all do things quite differently, with the exception of
> set_ftrace_filter and set_ftrace_notrace.
> 
> Note, all your patches have [PATCH 0/3] in the subject. I think I can
> figure out the order, but you will want to fix that on your next
> version.

oops, script fault ;) I resent v2, plz check

> 
> Currently I'm bug fixing other areas that need a bit of attention. I'll
> add this to my queue.

thanks,
jirka

> 
> Thanks,
> 
> -- Steve
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/