lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 5 Sep 2009 12:46:29 +0200 From: Mikael Pettersson <mikpe@...uu.se> To: Linus Torvalds <torvalds@...ux-foundation.org> Cc: Mikael Pettersson <mikpe@...uu.se>, "Rafael J. Wysocki" <rjw@...k.pl>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Kernel Testers List <kernel-testers@...r.kernel.org>, Alan Cox <alan@...ux.intel.com>, Greg KH <gregkh@...e.de>, Andrew Morton <akpm@...ux-foundation.org>, OGAWA Hirofumi <hirofumi@...l.parknet.co.jp> Subject: Re: [Bug #14015] pty regressed again, breaking expect and gcc's testsuite Linus Torvalds writes: > > > On Fri, 4 Sep 2009, Linus Torvalds wrote: > > > > I'm sure you already figured the obvious meaning out, but here's a fixed > > version. > > And here's another patch that may also fix this, simply by virtue of > writing the "\r\n" as a single string, rather than as two characters. That > way, we should never get into the situation that th '\r' allocates a new > buffer (larger than one character), and then the later '\n' writing > decides that we've filled up. Thanks, I'm testing this and the pty_write() fix on i686 and ppc64 now. Sometimes the bug is difficult to trigger, so I may need to do loads of testing with different gcc versions before I dare to say that it's fixed. /Mikael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists