linux-kernel - Re: [PATCH 2/2] leds: Add WM831x status LED driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1252331484.17852.50.camel@dax.rpnet.com>
Date:	Mon, 07 Sep 2009 14:51:24 +0100
From:	Richard Purdie <rpurdie@...ys.net>
To:	Pavel Machek <pavel@....cz>
Cc:	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	linux-kernel@...r.kernel.org, Samuel Ortiz <sameo@...ux.intel.com>
Subject: Re: [PATCH 2/2] leds: Add WM831x status LED driver

On Mon, 2009-09-07 at 15:22 +0200, Pavel Machek wrote:
> On Sat 2009-09-05 14:09:21, Mark Brown wrote:
> > The WM831x devices feature two software controlled status LEDs with
> > hardware assisted blinking.
> > 
> > The device can also autonomously control the LEDs based on a selection
> > of sources.  This can be configured at boot time using either platform
> > data or the chip OTP.  A sysfs file in the style of that for triggers
> > allowing the control source to be configured at run time.  Triggers
> > can't be used here since they can't depend on the implementation details
> > of a specific LED type.
> 
> I believe people *were* doing that with triggers in other drivers...?

We did talk about allowing the LED triggers to choose whether they were
visible to a given LED. At present the mechanism doesn't exist because
we've never had a user.

It would just be a case of adding a new optional function to the trigger
to say whether it supported a given LED or not and calling that function
from led_trigger_show().

I've queued this driver but that would be a nice enhancement.

Cheers,

Richard

-- 
Richard Purdie
Intel Open Source Technology Centre

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/