linux-kernel - Re: Zaurus suspend saga

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 7 Sep 2009 22:52:18 +0800
From:	Eric Miao <eric.y.miao@...il.com>
To:	Richard Purdie <rpurdie@...ys.net>
Cc:	Stanislav Brabec <utx@...guin.cz>, Pavel Machek <pavel@....cz>,
	lenz@...wisc.edu, kernel list <linux-kernel@...r.kernel.org>,
	Dirk@...er-online.de, arminlitzel@....de,
	Cyril Hrubis <metan@....cz>, thommycheck@...il.com,
	linux-arm-kernel <linux-arm-kernel@...ts.arm.linux.org.uk>,
	dbaryshkov@...il.com, omegamoon@...il.com, eric.miao@...vell.com,
	Andrea Adami <andrea.adami@...il.com>
Subject: Re: Zaurus suspend saga

On Mon, Sep 7, 2009 at 10:07 PM, Richard Purdie<rpurdie@...ys.net> wrote:
> On Mon, 2009-09-07 at 15:10 +0200, Stanislav Brabec wrote:
>> Pavel Machek wrote:
>> >
>> > > Sadly lack of time means I've lost track of the Zaurus kernels but this
>> > > sounds like all accesses to the SSP buses now go through the SPI layer
>> > > and when it was converted nobody thought about the impact this would
>> > > have on the Zaurus charger code.
>> >
>> >Unfortunately... Do you have any idea when this conversion took place?
>>
>> In past, MAX1111 driver was embedded in the Zaurus specific code. Now
>> MAX1111 is a generic SPI driver and spitz_pm.c calls it.
>>
>> Maybe it will still work with CONFIG_CORGI_SSP_DEPRECATED.
>
> I was thinking about this. The SSP interface is ridiculously simple and
> it might be worth just adding some SSP access code into the Zaurus
> offline code so it can access the MAX1111 without the rest of the system
> running. That would solve a lot of the problems.
>

That simple SSP API made a lot of headaches as well. Now there are three
clearly separated individual drivers even on a single SPI bus controlling the
LCD, backlight and the MAX1111 sensor instead of all those dirty tricks
messing up. And it was really a painful memory to touch that part of the
code and get it cleaned up.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/