linux-kernel - Re: WARNINGs in usb-serial.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.0909071101010.7175-100000@netrider.rowland.org>
Date:	Mon, 7 Sep 2009 11:08:25 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Miklos Szeredi <miklos@...redi.hu>
cc:	alan@...ux.intel.com, <gregkh@...e.de>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: WARNINGs in usb-serial.c

On Mon, 7 Sep 2009, Miklos Szeredi wrote:

> Here's a reproducible Oops on that kernel when trying to connect with
> wvdial.  This is a regression compared to -linus, where wvdial works
> (most of the time anyway).
> 
> I can bisect it if it's not immediately obvious what is happening...

I don't think bisecting will help (or is even possible).

> BUG: unable to handle kernel NULL pointer dereference at 0000000000000018
> IP: [<ffffffffa020709c>] serial_chars_in_buffer+0x47/0x5f [usbserial]

It's difficult to say without an assembly listing, but I gather that
serial_chars_in_buffer() is seeing port->serial == NULL.  Can you
verify this?

This is unexpected, because port->serial is initialized in
usb_serial_probe() and is not set to NULL until destroy_serial(), after
which port should not be used at all.  Can you add a

#define DEBUG

line at the start of usb-serial.c (before the #include lines) so that
we can tell if destroy_serial() is getting called too early?  When you
do, post the dmesg log showing everything from the time you start
running your test.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/