linux-kernel - Re: vfs-fix-d_path-for-unreachable-paths.patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1252312254.4733.12.camel@tucsk>
Date:	Mon, 07 Sep 2009 10:30:54 +0200
From:	Miklos Szeredi <mszeredi@...e.cz>
To:	Valdis.Kletnieks@...edu
Cc:	Hugh Dickins <hugh.dickins@...cali.co.uk>, miklos@...redi.hu,
	Andrew Morton <akpm@...ux-foundation.org>,
	Matthew Wilcox <matthew@....cx>,
	Andreas Gruenbacher <agruen@...e.de>,
	Al Viro <viro@...iv.linux.org.uk>,
	Christoph Hellwig <hch@....de>, linux-kernel@...r.kernel.org
Subject: Re: vfs-fix-d_path-for-unreachable-paths.patch

On Sat, 2009-09-05 at 10:22 -0400, Valdis.Kletnieks@...edu wrote:
> Somebody is buggy here, but I'm not sure who. The initrd for leaving a dangling
> reference, the patch for breaking /proc/mounts, or /sbin/restorecon and the
> shutdown script for being far too trusting of what the kernel tells it?
> 

Hugh Dickins reported a similar issue, where gnome-vfs chokes on
that /proc/mounts line as well.

I think the conclusion is that this change in /proc/mounts is not going
to work.  There are two solutions:

 1) leave out unreachable mounts from /proc/PID/mounts altogether
 2) completely revert /proc/PID/mounts to the old behavior

The first option is much less likely to break something than the current
patch, but it's still an ABI change.

So I think it's better to go with the second option.  Patches coming
up...

Thanks,
Miklos


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/