linux-kernel - Re: [PATCH] x86: Fix code patching for paravirt-alternatives on 486

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 09 Sep 2009 01:46:35 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	x86@...nel.org, linux-kernel@...r.kernel.org,
	Richard Kettlewell <rjk@...raraq.org.uk>
Subject: Re: [PATCH] x86: Fix code patching for paravirt-alternatives on 486

On Tue, 2009-09-08 at 17:31 -0700, H. Peter Anvin wrote:
[...]
> I'm wondering if it wouldn't be cleaner to fold the jump into
> sync_core() and moving the sync_core() up before local_irq_restore().

Exactly as I suggested below the dashes. :-)

The only reason I didn't do that initially was that I don't know whether
or not there's a good reason for the current placement of sync_core()
after local_irq_restore().

Ben.

-- 
Ben Hutchings
Who are all these weirdos? - David Bowie, about L-Space IRC channel #afp

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)