[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Wed, 09 Sep 2009 17:42:19 +0300
From: Avi Kivity <avi@...hat.com>
To: Julia Lawall <julia@...u.dk>
CC: kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 3/9] virt/kvm: correct error-handling code
On 07/28/2009 06:53 PM, Julia Lawall wrote:
> From: Julia Lawall<julia@...u.dk>
>
> This code is not executed before file has been initialized to the result of
> calling eventfd_fget. This function returns an ERR_PTR value in an error
> case instead of NULL. Thus the test that file is not NULL is always true.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> //<smpl>
> @match exists@
> expression x, E;
> statement S1, S2;
> @@
>
> x = eventfd_fget(...)
> ... when != x = E
> (
> * if (x == NULL || ...) S1 else S2
> |
> * if (x == NULL&& ...) S1 else S2
> )
> //</smpl>
>
>
Applied, thanks (yes, old patch, missed it).
--
error compiling committee.c: too many arguments to function
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists