linux-kernel - Re: [PATCH] SCSI driver for VMware's virtual HBA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 09 Sep 2009 09:56:52 -0700
From:	Alok Kataria <akataria@...are.com>
To:	Rolf Eike Beer <eike-kernel@...tec.de>
Cc:	Daniel Walker <dwalker@...o99.com>,
	James Bottomley <James.Bottomley@...e.de>,
	Brian King <brking@...ux.vnet.ibm.com>,
	"Chetan.Loke@...lex.Com" <Chetan.Loke@...lex.com>,
	Matthew Wilcox <matthew@....cx>,
	Roland Dreier <rdreier@...co.com>,
	Bart Van Assche <bvanassche@....org>,
	Robert Love <robert.w.love@...el.com>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Mike Christie <michaelc@...wisc.edu>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"pv-drivers@...are.com" <pv-drivers@...are.com>
Subject: Re: [PATCH] SCSI driver for VMware's virtual HBA - V4.

Hi Eike,

On Tue, 2009-09-08 at 22:54 -0700, Rolf Eike Beer wrote:
> Alok Kataria wrote:
> 
> > +/* Command line parameters */
> > +static int pvscsi_ring_pages     = PVSCSI_DEFAULT_NUM_PAGES_PER_RING;
> > +static int pvscsi_msg_ring_pages = PVSCSI_DEFAULT_NUM_PAGES_MSG_RING;
> > +static int pvscsi_cmd_per_lun    = PVSCSI_DEFAULT_QUEUE_DEPTH;
> > +static int pvscsi_disable_msi;
> > +static int pvscsi_disable_msix;
> > +static int pvscsi_use_msg        = true;
> 
> Should be bool.

Yeah, could be done, though I think I will do this later as an
incremental change or piggyback it if something else comes up.

> 
> Do I get annoying? ;)

:) Do you want the truth ? ;).

Actually its good that the code is being reviewed in so much details.
Thanks for your time on this.

--Alok 

> 
> Eike

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/