| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 9 Sep 2009 13:01:10 -0500 From: Jack Steiner <steiner@....com> To: Daniel Walker <dwalker@...o99.com> Cc: mingo@...e.hu, tglx@...utronix.de, linux-kernel@...r.kernel.org Subject: Re: [PATCH] x86: SGU UV Add volatile to macros that access chipset registers On Wed, Sep 09, 2009 at 09:10:00AM -0700, Daniel Walker wrote: > On Wed, 2009-09-09 at 10:42 -0500, Jack Steiner wrote: > > Add "volatile" to the SGI UV read/write macros that are used to access chipset > > memory mapped registers. > > There is a considerable document regarding the usage of volatile in the > kernel (Documentation/volatile-considered-harmful.txt). Considering that > document, can you give a more descriptive reason why your using > "volatile" here ? > I knew that "volatile" would catch someone's attention :-) Volatile is being added to the accessor functions that are used to read/write memory-mapped I/O registers located within the UV chipset. The use of volatile is hidden within the functions and is not exposed to the users of the functions. Note that the use is limited to the accessor functions in the header file. No .c files are changed or need to know about volatile. This seems to be consistent with other uses of volatile within the kernel. --- jack -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists