linux-kernel - Re: [PATCH 1/2] tracing: Add sysctl to enable/disable tracing on oops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1252464784.12982.4.camel@gandalf.stny.rr.com>
Date:	Tue, 08 Sep 2009 22:53:04 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Li Zefan <lizf@...fujitsu.com>
Cc:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Ingo Molnar <mingo@...e.hu>,
	Frederic Weisbecker <fweisbec@...il.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] tracing: Add sysctl to enable/disable tracing on
 oops

On Wed, 2009-09-09 at 10:40 +0800, Li Zefan wrote:

> > I have another silly question.
> > Why should we call tracing_off() in oops_enter()?
> > 
> 
> I guess it's because trace outputs generated during oops can
> overwrite/mess up those generated before oops?
> 
> It was added by this commit, but I can't find trace_printk_on_oops.

That's because Thomas did not bother looking up the actual variable he
was talking about. s/trace_printk_on_oops/ftrace_dump_on_oops/

-- Steve

> 
> commit bdff78707f3ce47e891f3201c9666122a70556ce
> Author: Thomas Gleixner <tglx@...utronix.de>
> Date:   Fri Jul 24 15:30:45 2009 -0400
> 
>     trace: stop tracer in oops_enter()
> 
>     If trace_printk_on_oops is set we lose interesting trace information
>     when the tracer is enabled across oops handling and printing. We want
>     the trace which might give us information _WHY_ we oopsed.
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/